Hey Jussi,

For these particular patches it doesn't matter that much. We can of
course handle them. It's just that for future patches we prefer the
format-patch format.

As you point out are these lacking the comment-body (and every commit
needs a comment body for us).

Cheers, thanks for the patches. We'll look into them and merge them to
master soon.

Philip

On Wed, 2011-01-26 at 13:47 +0200, Jussi Kukkonen wrote:
> On 01/26/2011 01:12 PM, Philip Van Hoof wrote:
> > 
> > Hey Jussi,
> > 
> > Can you use git format-patch for your patches next time? This gives us a
> > patch that keeps among other things the message, date and author of the
> > commit.
> 
> I can do that if you wish but I don't think there's any info missing: I
> used git send-email and that should contain all the info needed (the
> comment body is missing because I didn't think the commits needed any).
> I just tested using "git am" on my original email and it seems to do the
> right thing.
> 
> But it's your call (and I can use the bugzilla as well if that's the
> preferred way to get patches).
> 
>  - Jussi
> 

-- 


Philip Van Hoof
freelance software developer
Codeminded BVBA - http://codeminded.be

_______________________________________________
tracker-list mailing list
tracker-list@gnome.org
http://mail.gnome.org/mailman/listinfo/tracker-list

Reply via email to