Hi Martyn, On Thu, 2013-01-31 at 12:05 +0000, Martyn Russell wrote: > On 25/01/13 11:12, Frank Lahm wrote: > > Solaris libuuid is missing uuid_unparse_lower, it was a simple hack^wfix. :) > > Hmm, this worries me. We use the _lower() variant for a reason here and > it would obviously be faster to not use that. It might be a short term > fix for you, but I wonder if this causes regressions for you at all?
libuuid from util-linux 2.22 appears to default to lowercase. No idea about other versions or platforms, though. If I'm seeing this correctly, these function calls are not performance critical. Thus, we could always convert to lowercase in a separate step. > I think a patch like this is fine if we can do it only on platforms that > don't have that API. Jürg, did Vala get pre-processor directives yet? > i.e. #ifdef FOO, etc.? Vala supports #if for a long time, however, this wouldn't play well with autotools tarballs shipping generated C code. The conditionals are evaluated by valac, not by the C compiler. Jürg _______________________________________________ tracker-list mailing list tracker-list@gnome.org https://mail.gnome.org/mailman/listinfo/tracker-list
