Hey, Sorry it took long to reply, been more offline than first expected this extended weekend.
On jue, 2014-02-13 at 18:40 +0000, Martyn Russell wrote: > Hello all, > > So Carlos recently finished the prioritized-crawling branch¹. I am > reviewing it here because it is important people understand the changes > going on AND to give some feedback before merging. > > ¹ https://git.gnome.org/browse/tracker/log/?h=prioritized-crawling > > So comments: > > 1. How does this work affect Xavier's work on proritising > crawling/indexing? Some of the diff certainly looks like it would > conflict with Xavier's work. IMO this blends in just fine. Xavier's work focuses on the tracker-extract side, prioritizing certain files over others, but only after miner-fs has gotten the rdf:types that apply. With this branch, removable volumes and DBus IndexFile requests are crawled before any file from config, together with rdf:type prioritization this would mean the favoured rdf:types in removable volumes would be indexed the fastest, and at least basic information would be committed for any other file if the volume gets unmounted early. But I guess it still could be great Xavier's word here, I don't want to stomp on his work again :P. Cheers, Carlos > > **** > > Generally speaking I find the whole branch really well written. It > doesn't quite accomplish what Xavier wants yet (priority for file > types), but it does allow priority for directories and it's well used > for removable media so far. > > It might cause some conflicts with Xavier's branches/work, but it's a > step in the right direction I agree. > > I will merge this work as soon as I've heard back from you Carlos on the > first comment. Looks pretty safe to commit though. > > Thanks again! > _______________________________________________ tracker-list mailing list tracker-list@gnome.org https://mail.gnome.org/mailman/listinfo/tracker-list
