-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Carlos,
I committed this for review in a branch: https://git.gnome.org/browse/tracker/log/?h=crawler-max-depth Is this ~ what you proposed? Kind regards, Philip On 13/08/2014 0:13, Carlos Garnacho wrote: > Hey Philip, > > Sorry I missed this... > > > On Tue, Jul 8, 2014 at 9:48 AM, Philip Van Hoof > <phi...@codeminded.be> wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >> Hi guys, >> >> As you know I'm tailing the Tracker package for the Jolla device >> and I noticed that there a bugfix was made by Richard Braakman >> for a change that happened recently: >> >> https://github.com/nemomobile-packages/tracker/pull/29 >> >> Commit here: >> >> https://github.com/amtep/tracker/commit/419d680619b5e0d4f3ae308a087dd313e8ce252e > >> > > > I see how spurious ::file-deleted might happen, the > TrackerFileSystem caches data for directories, so if a reindex > happens on a directory that happened to preserve data, > tracker_file_system_traverse() would recurse deep in the old tree > while the crawling phase only updated the most direct children at > that time. > > I however think a better fix would be to add a max_depth parameter > to tracker_file_system_traverse(), and pass the same depth that's > given on tracker_crawler_start() (and implicitly performed in > queries). AFAICS the approach in the patch would still fail for > files deeper than MAX_DEPTH, as those won't be yet in the > pending_files array. TrackerFileSystem is private, so API changes > are just fine there. > > Cheers, Carlos > > > > _______________________________________________ tracker-list > mailing list tracker-list@gnome.org > https://mail.gnome.org/mailman/listinfo/tracker-list > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (MingW32) iQEcBAEBAgAGBQJUlDTyAAoJEEP2NSGEz4aD05EIAJADVNG32kW8g0p+L8rQbN+t SXjzbrIr3clYT/oLNZ1H0QDD3LZzBImpEwzp1Trxr5qiu5kJTDauX1Bm6mDPaRid dhxNsqDE+NgRCCu9IgV+zASVW5JNzE2WpmfIIPyHKZOWOz+68A90u0zabizL8sP7 oWUg5nNQhuoOq3DHhZVEW1mwkEqVHTZT6z9ve/II3HQlWWQ3PwL+24ixmyRYPmsf nrcJ5hm/LGhXRhqOd8TJUvRGtVoJl4Y6AFXIbP/bXCFzIWSNsdpCBdsJOvP8w9ye 2YZogwmMW7fvC6hAe3QJL0VllwciamQahJ41dNt4X9BOBkN4R6uVIk/F0CvwxSs= =C2y3 -----END PGP SIGNATURE----- _______________________________________________ tracker-list mailing list tracker-list@gnome.org https://mail.gnome.org/mailman/listinfo/tracker-list
