On Thu, 29 Jun 2006 08:26:04 +0200 Francesco Romani <[EMAIL PROTECTED]> wrote:
> Now *frame_list_t structure ships length and size fields, were size is > the real size of buffer, and length is the amount of valid data stored > in buffer. This looked to me as quite clean and less painful soluction > avalaible, so I've commited; except for removal of an unused field > (plane_mode, nonbody cares about it) and a field reordering, nothing is > changed, so nothing is supposed to be broken. > > For uncompressed frame, we have length == size, but for encoded frame > (passed around between demultiplexor and decoder and between encoder > and multiplexor), it will be length <= size, so length matters here > and here it's supposed to be useful ;) Thanks for taking care about this and for pointing it out. However I wonder if "length <= size" is a safe assumption for encoded frames. Can we be sure that also lossless codecs will always produce encoded frames that are smaller than the decoded input frames? > This concept was also explained with other words in a comment on > CVS in src/framebuffer.h. Just let me know if neither explanation is > clear enough (!!). Both explanations look well understandable to me. > encode_x264 was fixed (as well as existing encoders/multiplexors module) > and seems to produce at least watchable streams now. The changes from 1.2 to 1.4 look reasonable to me. Now I just have to catch up to 1.5 ;-) Regards, Christian Bodenstedt
