I got the following mail some time ago, but I don't have time to look
into the details at the moment. Anyone else want to take a stab at this?
--Andrew Church
[EMAIL PROTECTED]
http://achurch.org/
Subject: tcmodinfo and the compare filter
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Date: Tue, 20 Jun 2006 00:13:59 +0300
Hi Andrew,
First, sorry about mailing you directly, but I'd rather not subscribe to
yet another mailing list for this small a thing: I noticed that you had
done the last quite a few commits to transcode's filter_compare.c, so
maybe you could comment on this:
$ tcmodinfo -i compare
[filter_compare.so] options=help
could not open file for writing: No such file or directory
The problem is that tcmodinfo just sits there (after the filter is
trying to write something to some file somewhere???), and never returns
without a Ctrl-C. See also
http://bugzilla.livna.org/show_bug.cgi?id=987
See attached patch (against transcode 1.0.2), do you think something
like that would be the right thing to do?
--- filter/filter_compare.c~ 2005-07-04 10:09:32.000000000 +0300
+++ filter/filter_compare.c 2006-06-20 00:12:16.000000000 +0300
@@ -154,6 +154,11 @@
compare[instance]->height = compare[instance]->vob->ex_v_height;
if (options != NULL) {
+ if (optstr_lookup (options, "help")) {
+ help_optstr();
+ return(0);
+ }
+
char pattern_name[PATH_MAX];
char results_name[PATH_MAX];
memset(pattern_name,0,PATH_MAX);
@@ -208,12 +213,6 @@
perror("Not image provided");
}
- if (options != NULL)
- if (optstr_lookup (options, "help")) {
- help_optstr();
- }
-
-
fprintf(compare[instance]->results,"#fps:%f\n",compare[instance]->vob->fps);
if (orig != NULL){
