>Since we're talking about src/* content, feel free to comment/blame me about
>new framebuffer code recently committed by myself.
Okay, if you insist ;) I was working on getting the tests in
newtest.pl to pass again, and noticed that the "free" index and video_buf
pointer in vframe_list_t are getting out of sync (the current code will
output a "BUG" warning every time you start transcoding and fix the
problem on its own). Do you have any idea where that might be happening?
>Maybe split configuration values (the hard part is to properly identify
>them) from stream properties in vob_t can be a feasible way?
>Anyway, unless someone brave enough take care of this, it's definitively
>a far future job for me.
I agree, it's not something that needs immediate work, though if I
ever find myself with more free time (yeah, right ;) I may look into it.
>> * The undocumented long option names for most of the short options have
>> changed, e.g. -i is now --input instead of --input_file.
>
>We really need long option name aliases for each short option?
>I've nothing against those, I just wonder if this (in general sense)
>is an overkill or not.
One of my thoughts has been (perhaps when we get the NMS framework
finally worked out and polished up, definitely a long time in the future)
to reassign the short option letters in a way that makes more sense, so
the obvious thing to do before that would be to temporarily drop the short
options entirely and get people used to the long ones. In any case, it
seems more sensible to me to give every option a long name and have
abbreviations for common ones, than to have some options with short
forms only and some with long forms only.
> * --keep_asr is now disabled, as the code implementing it is broken (it
>> doesn't interact properly with other options). If you need to keep
>> the same aspect ratio, calculate the appropriate values manually.
>
>Maybe that should be reintroduced for 1.1.0? I'll take a look later to
>figure out what's wrong (I've a very few clues right now :) ).
I don't know; I'd tend more toward dropping it completely, both
because there's really no way to get it working (that I can think of)
without making the interactions with -j -Z -Y etc. very confusing--
remember all the trouble we had with export profiles doing the same
thing?--and also because you can already use e.g. -Z 352x or -Z x288 to
maintain aspect ratio when zooming, so there doesn't seem to be too much
need for --keep_asr in the first place.
> * --color is now gone entirely, because it didn't actually do anything.
>
>IIRC the purpose was to avoid that ANSI terminal color sequences screw
>output if stdout was not-term (file...).
>I've nothing about --color removal, anyway.
I'm pretty sure you're right about what it was supposed to do, but
since libtc didn't pay it any attention it wasn't really meaningful. ;)
It might still be a good idea to implement a switch like that, but that
can be re-added after the code to handle it is in place, rather than
trying to drag around old code that wasn't designed for it.
--Andrew Church
[EMAIL PROTECTED]
http://achurch.org/
