Hi Francesco,
On Sunday, November 13, 2011 10:52:11 AM Francesco Romani wrote:
> On 11/09/2011 12:00 AM, Georg Martius wrote:
> > Hi Francesco,
> >
> > thanks for the release. I just realized that there seemed to be patch
> > missing for the transform filter. It was quite a big one for the 0.77
> > version. It brings performance optimization for the transform step by a
> > factor of 2 or so. It was probably my fault, I have missed it in my hg
> > branch for some reason. Attached is a diff of the stabililze directory
> > and the final files. Sorry about that.
>
> Applied. (direct link to the branch:
> https://bitbucket.org/france/transcode-tcforge/src/08c41b03db84)
> Please confirm everything looks ok now.
Yes, great. I attached a small patch to update the Changelog and reintroduce
your code cosmetics, that was overwritten.
BTW: you added a do{ ... } while(0) into CHECKPARAM macro in filter_transform.c
(in 4096:a22b117aced2), we that? I didn't add it again.
Thanks, and sorry again for the trouble.
Regards,
Georg
PS: When you announce the new version, please do it in a new thread, that one
can see it easier in the archives...
# HG changeset patch
# User Georg Martius <georg dot martius at web dot de>
# Date 1321201667 -3600
# Branch transcode-1_1
# Node ID 8a6c8e86458232c4e964ff3cd325b197f3535b54
# Parent 08c41b03db84570e8a4f41e69f52761786505cc0
changelog updated for 0.80
Francesco's code cosmetic redone
diff -r 08c41b03db84 -r 8a6c8e864582 filter/stabilize/Changelog
--- a/filter/stabilize/Changelog Sun Nov 13 10:38:04 2011 +0100
+++ b/filter/stabilize/Changelog Sun Nov 13 17:27:47 2011 +0100
@@ -1,3 +1,6 @@
+0.80
+ keep border mode in transform plugin improved
+
0.79
speed optimizations using SSE by Alexey Osipov
search tree cut, spiral search and sse:
diff -r 08c41b03db84 -r 8a6c8e864582 filter/stabilize/filter_transform.c
--- a/filter/stabilize/filter_transform.c Sun Nov 13 10:38:04 2011 +0100
+++ b/filter/stabilize/filter_transform.c Sun Nov 13 17:27:47 2011 +0100
@@ -778,8 +778,9 @@
td = self->userdata;
td->vob = vob;
- if (!td->vob)
+ if (!td->vob) {
return TC_ERROR; /* cannot happen */
+ }
/**** Initialise private data structure */
@@ -914,7 +915,7 @@
}
/* Is this the right point to add the filter? Seems to be the case.*/
- if(td->sharpen>0){
+ if (td->sharpen > 0) {
/* load unsharp filter */
char unsharp_param[256];
sprintf(unsharp_param,"luma=%f:%s:chroma=%f:%s",
@@ -1017,7 +1018,7 @@
}
/* checks for parameter in function _inspect */
-#define CHECKPARAM(paramname, formatstring, variable) \
+#define CHECKPARAM(paramname, formatstring, variable) \
if (optstr_lookup(param, paramname)) { \
tc_snprintf(td->conf_str, sizeof(td->conf_str), \
formatstring, variable); \
