2011-10-27 10:07 keltezéssel, Bjoern Voigt írta:
Hi,

if I start a audio call in Pidgin, the menu of the audio call
window contains untranslated strings (see attached screenshot).
The German translation file contains the translations for the
strings "_Hangup" and "_Media".

I looked up the source code and everything looks fine in
pidgin/gtkmedia.c:

         action_group = gtk_action_group_new("MediaActions");
         gtk_action_group_add_actions(action_group,
                                      menu_entries,
                                      G_N_ELEMENTS(menu_entries),
                                      GTK_WINDOW(window));
#ifdef ENABLE_NLS
         gtk_action_group_set_translation_domain(action_group,
                                                 PACKAGE);
#endif

Is config.h (which defines ENABLE_NLS) included? It should be.

I also tried to change to order of gtk_action_group_add_actions
and gtk_action_group_set_translation_domain but this also did not
solve the problem.

This was a good idea in itself, this change had no effect only because of the former problem.

After applying the attached patch to the 2.10.0 tarball, the resulting screenshot looks like this:

http://people.ubuntu.com/~kelemeng/pix/K%C3%A9perny%C5%91k%C3%A9p-heimt.png

Bonus: it marks the two buttons at the bottom of the window for translation :).

Regards
Gabor Kelemen
--- pidgin-2.10.0-orig/pidgin/gtkmedia.c	2011-10-27 11:57:13.846248179 +0200
+++ pidgin-2.10.0/pidgin/gtkmedia.c	2011-10-27 12:35:45.975239644 +0200
@@ -23,6 +23,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02111-1301  USA
  */
 
+#include "config.h"
+
 #include "internal.h"
 #include "debug.h"
 #include "connection.h"
@@ -290,15 +292,16 @@
 	GtkWidget *menu;
 
 	action_group = gtk_action_group_new("MediaActions");
-	gtk_action_group_add_actions(action_group,
-	                             menu_entries,
-	                             G_N_ELEMENTS(menu_entries),
-	                             GTK_WINDOW(window));
 #ifdef ENABLE_NLS
 	gtk_action_group_set_translation_domain(action_group,
 	                                        PACKAGE);
 #endif
 
+	gtk_action_group_add_actions(action_group,
+	                             menu_entries,
+	                             G_N_ELEMENTS(menu_entries),
+	                             GTK_WINDOW(window));
+
 	window->priv->ui = gtk_ui_manager_new();
 	gtk_ui_manager_insert_action_group(window->priv->ui, action_group, 0);
 
@@ -789,7 +792,7 @@
 
 		/* Hold button */
 		gtkmedia->priv->hold =
-				gtk_toggle_button_new_with_mnemonic("_Hold");
+				gtk_toggle_button_new_with_mnemonic(_("_Hold"));
 		gtk_box_pack_end(GTK_BOX(button_widget), gtkmedia->priv->hold,
 				FALSE, FALSE, 0);
 		gtk_widget_show(gtkmedia->priv->hold);
@@ -878,7 +881,7 @@
 
 	if (type & PURPLE_MEDIA_SEND_AUDIO) {
 		gtkmedia->priv->mute =
-				gtk_toggle_button_new_with_mnemonic("_Mute");
+				gtk_toggle_button_new_with_mnemonic(_("_Mute"));
 		gtk_box_pack_end(GTK_BOX(button_widget), gtkmedia->priv->mute,
 				FALSE, FALSE, 0);
 		gtk_widget_show(gtkmedia->priv->mute);
_______________________________________________
Translators mailing list
[email protected]
http://pidgin.im/cgi-bin/mailman/listinfo/translators

Reply via email to