Alissa Cooper has entered the following ballot position for draft-ietf-trill-smart-endnodes-10: Discuss
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html for more information about IESG DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-trill-smart-endnodes/ ---------------------------------------------------------------------- DISCUSS: ---------------------------------------------------------------------- This should hopefully be easy to fix and was pointed out by the Gen-ART reviewer: All of section 4.3 is confusing as to what the length of the TLV really is. Row 3 in the diagram says 2 bytes or 4 bytes, but the number of bits called out in bullets 4 and 5 below it don't seem to add up to those things. Maybe it would be better to draw a diagram with F=0 and a separate diagram with F=1. Please make it clear both in the diagram and in the text what the expected lengths of the fields are -- I find it particularly confusing that the number of bits pictured doesn't align with the number of bits specified in the text per field. ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Please also look at the Gen-ART reviewer's other comments. _______________________________________________ trill mailing list trill@ietf.org https://www.ietf.org/mailman/listinfo/trill