On Tue, Jun 11, 2013 at 06:21:08PM -0400, Vince Weaver wrote:
> On Tue, 11 Jun 2013, Dave Jones wrote:
>
> > yeah, that's what I've done in a lot of other places (actually BUG() in
> > those cases).
> > For the most part they're present just to shut up -Wswitch-default, which
> > has caught a few cases in the past where I've missed an option.
>
> I'll go back through and check out all of the switch statements (there
> are a lot of them) and make sure they handle the default case
> consistently.
>
> > ok, I'll apply what you sent so far. (and hold off on running it through
> > Lindent for now,
> > you really don't like whitespace huh? ;)
>
> Not enough whitespace? Or over-use of tabs?
Mostly stuff like this. ..
if((foo&bar)==0) i=rand();
instead of
if ((foo & bar) == 0)
i = rand();
indent -kr gets it mostly right. I tried bending the kernels scripts/Lindent to
fit,
but I'm still not 100% happy. It's good for a start point though.
Dave
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html