Re: [PATCH] ioctls: videodev2: check if defines are obsolete

[Tommi Rantala]

2013/7/24 Andi Shyti <a...@etezian.org>:
> In kernel headers 3.11 the VIDIOC_DBG_G_CHIP_IDENT define is
> considered obsolete, therefore removed, generating the following
> compiling error:
>
> ioctls/videodev2.c:72:15: error: ‘VIDIOC_DBG_G_CHIP_IDENT’ undeclared here 
> (not in a function)
>   IOCTL(VIDIOC_DBG_G_CHIP_IDENT),
>                ^
>
> Check the definition of it before using it
>
> Signed-off-by: Andi Shyti <a...@etezian.org>

Thanks, looks good!

> ---
>  ioctls/videodev2.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/ioctls/videodev2.c b/ioctls/videodev2.c
> index 0d1473e..03a5ae5 100644
> --- a/ioctls/videodev2.c
> +++ b/ioctls/videodev2.c
> @@ -69,7 +69,9 @@ static const struct ioctl videodev2_ioctls[] = {
>         IOCTL(VIDIOC_TRY_ENCODER_CMD),
>         IOCTL(VIDIOC_DBG_S_REGISTER),
>         IOCTL(VIDIOC_DBG_G_REGISTER),
> +#ifdef VIDIOC_DBG_G_CHIP_IDENT
>         IOCTL(VIDIOC_DBG_G_CHIP_IDENT),
> +#endif
>         IOCTL(VIDIOC_S_HW_FREQ_SEEK),
>  #ifdef VIDIOC_ENUM_DV_PRESETS
>         IOCTL(VIDIOC_ENUM_DV_PRESETS),
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe trinity" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html