On Tuesday, 30 April 2013 07:16:21 CEST, Sreepriya Chalakkal wrote:
I had made changes to composeWidget.cpp and its header.
I have incorporated the changes that you suggested. Kindly
review and give suggestions.
Hi, thanks for the patch. Bonus points for sending it to the mailing list --
that's how it's supposed to be done!
+ connect(edit,SIGNAL(textChanged(QString)),this, SLOT(slotCheckAddress()));
Whitespace issue.
- The ComposeWidget::slotCheckAddress() still sets a green background for valid
addresses. I find that distracting. Wouldn't it be better if the background was
QPalette::Base by default and changed to red when there was a non-empty but
invalid e-mail address?
- The git branch contains extra changes (the README file) and also unrelated
commits. Some of the commits were made with an invalid e-mail address. I need a
branch with just a single commit on top of current master branch (7a434c3).
- The changelog message (or "commit mesage") should not start with "The commit
containing the patch for"; that's just noise. The best practices for commit messages is a short,
one-line summary (<80 characters, perhaps) followed by a blank line followed by a longer
description. Good editors even offer proper highlighting which will help you stick to this format.
Cheers,
Jan
--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
