On Friday 09 August 2013 18:15:41 Jan Kundrát wrote:
> On Thursday, 8 August 2013 17:00:10 CEST, Pali Rohár wrote:
> > As Kevin wrote, protection against emitting signals.
> 
> Looking at the code, it seems to me that the only connections
> are to ComposeWidget::completionDone which looks like a safe
> thing, even if it was called during stop() (is it?).
> 
> Jan

In ComposeWidget code job can emit completionAvailable or error 
signals. And job stop() method emitting error signal (with 
stopped enum). So I need to prevent calling slots from 
ComposeWidget which are conncted to job error signal.

So what about chaging code
disconnect(jobSecond, 0, 0, 0);
to
disconnect(jobSecond, 0, this, 0);
?

-- 
Pali Rohár
[email protected]

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to