Kent,
One other problem I noticed. Apparently the file
src/tpm_mgmt/tpm_nvcommon.h did not make it into the tpm-tools tar ball,
so tpm-tools-1.3.7 doesn't build, even with the updated trousers. There
were a couple of minor tweaks required - primarily removing the -Werror
flags from CFLAGS to get the package to build.
The only other changes I made to trousers to get the beast to build
were:
diff -up trousers-0.3.7/src/tspi/obj_migdata.c.orig
trousers-0.3.7/src/tspi/obj_migdata.c
--- trousers-0.3.7/src/tspi/obj_migdata.c.orig 2011-12-08
08:42:15.453933323 -0700
+++ trousers-0.3.7/src/tspi/obj_migdata.c 2011-12-08
08:45:36.042926315 -0700
@@ -385,7 +385,7 @@ obj_migdata_get_msa_list(TSS_HMIGDATA hM
done:
obj_list_put(&migdata_list);
- return TSS_SUCCESS;
+ return result;
}
TSS_RESULT
@@ -502,7 +502,7 @@ obj_migdata_get_msa_list_blob(TSS_HMIGDA
done:
obj_list_put(&migdata_list);
- return TSS_SUCCESS;
+ return result;
}
TSS_RESULT
diff -up trousers-0.3.7/src/tspi/obj_nv.c.orig
trousers-0.3.7/src/tspi/obj_nv.c
--- trousers-0.3.7/src/tspi/obj_nv.c.orig 2011-12-08
08:35:19.565947629 -0700
+++ trousers-0.3.7/src/tspi/obj_nv.c 2011-12-08 08:39:54.285938217
-0700
@@ -467,7 +467,7 @@ obj_nvstore_get_writedigestatrelease(TSS
+ sizeof(TPM_COMPOSITE_HASH);
pcrwrite_sizeOfSelect = Decode_UINT16(nv_data_public + offset);
- offset = offset + sizeof(UINT16) + pcrread_sizeOfSelect +
sizeof(TPM_LOCALITY_SELECTION);
+ offset = offset + sizeof(UINT16) + pcrwrite_sizeOfSelect +
sizeof(TPM_LOCALITY_SELECTION);
memcpy(*data, nv_data_public + offset,
sizeof(TPM_COMPOSITE_HASH));
return result;
It appeared to me that in obj_migdata.c, that if we went to the trouble
of defining an error code in the event of a failure, that we should
return the error code to the caller.
The change to obj_nv.c is a little more problematic. I don't think tha
tit makes a difference, but since we had just pulled the length of the
pcrwrite size of select, it seemed appropriate to use that for the next
offset calculation, instead of the size pulled previously for the
pcrread size of select.
Charles
-----Original Message-----
From: Kent Yoder [mailto:[email protected]]
Sent: Thursday, December 15, 2011 8:01 AM
To: Fisher, Charles-p99463
Cc: [email protected]
Subject: Re: [TrouSerS-tech] Unable to build tpm-tools.1.3.7
Hi Charles,
On Tue, Dec 13, 2011 at 5:02 PM, <[email protected]> wrote:
> It appears that Stefan's patch for the NVRAM tools made it into
version
> 1.3.7 of the tpm-tools. Unfortunately, his patch to
src/trspi/trousers.c
> that provided the support functions for these tools has not yet made
it into
> a released version of trousers (0.3.7 latest). This makes it really
> difficult to build the latest tpm-tools .
Thanks for reporting this. Rajiv should be returning from vacation
on Monday -- I'll ask him to take a look at this.
Kent
>
>
> Charles
>
>
>
------------------------------------------------------------------------
------
> Systems Optimization Self Assessment
> Improve efficiency and utilization of IT resources. Drive out cost and
> improve service delivery. Take 5 minutes to use this Systems
Optimization
> Self Assessment. http://www.accelacomm.com/jaw/sdnl/114/51450054/
> _______________________________________________
> TrouSerS-tech mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/trousers-tech
>
--
IBM LTC Security
------------------------------------------------------------------------------
10 Tips for Better Server Consolidation
Server virtualization is being driven by many needs.
But none more important than the need to reduce IT complexity
while improving strategic productivity. Learn More!
http://www.accelacomm.com/jaw/sdnl/114/51507609/
_______________________________________________
TrouSerS-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/trousers-tech
