Hi Xiaokai, On Mon, Mar 4, 2013 at 4:15 AM, Wang, Xiaokai <[email protected]> wrote: > Hi all, > > > > Attach files are the patches I made about tpm-tools.
Thanks for the patches. It looks like they didn't get formatted correctly for git though. You can use git format-patch on your local repository to export patches. Please try this and resubmit. > I change the name tpm_getcap to tpm_getpermanentflags,so that don’t need > any other arguments to display TPM_PERMANENTFLAGS. > > > > One probem is below: > > + if (genericOptHandler > > + (argc, argv, "o:", hOpts, > > + sizeof(hOpts) / sizeof(struct option), parse, help) != > 0) > > + goto out; > > > > “o:” cann’t get rid of “:”, otherwise the argument ownerpassword value > will be 0x0 and the cmd will implement abnormal. > > The reason I am not very clear,please help debug that. Please take a look at how tpm_nvdefine.c handles the owner password. The argument for ownerpass should be optional. > > > If the patches have no other problems I hope you can apply them. Thank you! Your patch to man/man8/tpm_nvdefine.8 made me realize that the .8 manpages with .pod extensions don't even need to be in git, since they're regenerated at build time. I've removed them entirely in the "1.3.9" branch in git. All you need to do is patch the .pod file here. Thanks, Kent > > > > > Regards > > Xiaokai > > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
