Ceri, I'm already investigating this (read your email in the trousers-users list), but feel free to send a fix, if you already have one.
Em 23-10-2013 06:50, Ceri Coburn escreveu: > OK will move it over. I have also sent this email to trousers-tech so feel > free now to respond from there instead. Are there any particular coding > styles that need to be adhered to before I submit the patch, tab size, > indent size, etc.... I have actually found 2 more since which I believe I > have fixed, so I'll get them through too. > > -----Original Message----- > From: Joel Schopp [mailto:[email protected]] > Sent: 22 October 2013 18:49 > To: Ceri Coburn; [email protected] > Subject: Re: [TrouSerS-users] Memory leak in Tspi_Key_CertifyKey? > > On 10/19/2013 05:01 AM, Ceri Coburn wrote: >> Hi, >> >> Could someone confirm if there is a memory leak inside >> Tspi_Key_CertifyKey? Valgrind has picked up that the CertifyInfo >> structure is not being freed. Here is the offending call in >> tspi_certify.c >> >> |109 /* XXX free CertifyInfo */ >> | >> |110 *if *((result = TCS_API(tspContext)->CertifyKey(tspContext, > certifyTCSKeyHandle, >> | >> |111 keyTCSKeyHandle, &antiReplay, pCertAuth, >> 112 pKeyAuth, &CertifyInfoSize, &CertifyInfo, >> 113 &outDataSize, &outData))) >> 114 *return *result; >> >> There is also a comment that seems to mention it as an issue. Is >> there any particular reason it's not being freed? >> > This conversation should probably move over to trousers-tech. It does look > like it could be a problem area with a potential memory leak in the unlikely > even of that call failing. > > Can you share the valgrind output? Also if you would like to send a patch > with a signed-off-by line to trousers-tech we'd be happy to review it there > and assuming it passes review we can commit it to the git repository. > > > ______________________________________________________________________ > This email has been scanned by the Symantec Email Security.cloud service. > For more information please visit http://www.symanteccloud.com > ______________________________________________________________________ > > > ---------------------------------------------------------------------------- > -- > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most > from the latest Intel processors and coprocessors. See abstracts and > register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > _______________________________________________ > TrouSerS-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/trousers-users > > ______________________________________________________________________ > This email has been scanned by the Symantec Email Security.cloud service. > For more information please visit http://www.symanteccloud.com > ______________________________________________________________________ > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > _______________________________________________ > TrouSerS-tech mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/trousers-tech > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
