On 10/23/2013 03:07 PM, Ceri Coburn wrote:
> Here is fix for the first memory leak. Let me know if this will suffice.
> Should have another for tspi_certify tomorrow.
Thanks, comments inline below.
<snip>
> - TPM_ORD_MakeIdentity, TPM_ET_OWNER,
> &xsap)))
> + TPM_ORD_MakeIdentity, TPM_ET_OWNER,
> &xsap))){
You mail client appears to be magling this a bit by wrapping the line.
I'd suggest using git send-email instead of outlook. If git send-email
isn't an option you can google how to send patches using various other
email clients in a way that disables line wrap.
> + free(asymParms.parms);
> return result;
> + }
>
> /* Hash the Auth data */
> result = Trspi_HashInit(&hashCtx, TSS_HASH_SHA1);
> @@ -392,6 +394,7 @@ Tspi_TPM_CollateIdentityRequest(TSS_HTPM hTPM,
> /* in */
> error:
> authsess_free(xsap);
> free_key_refs(&caKey);
> + free(asymParms.parms);
> free(prgbIdentityBinding);
> free(prgbEndorsementCredential);
> free(prgbPlatformCredential);
> --
Other than the mangled lines this patch looks fine. Resend unmangled
and I'll add it to the commit queue.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
TrouSerS-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/trousers-tech
