Well, I guess a little too late... ;-) The code was originally check in during commit ccb08330 on Mon Aug 20 20:46:17 2007 +0000
________________________________________ From: Ken Goldman [[email protected]] Sent: Saturday, April 12, 2014 16:30 To: [email protected] Subject: Re: [TrouSerS-tech] [PATCH 12/17] Fixed memory leak in function Transport_TerminateHandle Probably too late for this code, but multiple returns are the source of many of these bugs. If you code: ptr = NULL; function execution that may or may not malloc the ptr; free(ptr); return; you'll never have missing or double frees, or freeing an uninitialized pointer. On 4/11/2014 5:51 AM, Fuchs, Andreas wrote: > The patch is not correct. The free may only be performed in case of > result == TSS2_SUCCESS. The current version has a potential > double-free. In case of error, RPC_ExecuteTransport_TP will falsely > free this memory. > ... > > This is going to be a major rewrite I fear... ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ TrouSerS-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/trousers-tech
