It seems a little bit arbitrary to me to do just skip_zero=False, while you do with_childs=True.
To be clear for the user I would prefer to see those options on class ChooseStockDateInit and to set those default there. So it is up to the user, what he wants and he is informed about what he gets. http://codereview.appspot.com/2192047/diff/1/product.py File product.py (right): http://codereview.appspot.com/2192047/diff/1/product.py#newcode159 product.py:159: :param skip_zero: a boolean to list also items with zero quantity a boolean to not list items with zero quantity http://codereview.appspot.com/2192047/ -- [email protected] mailing list
