http://codereview.tryton.org/264001/diff/1/trytond/model/fields/property.py
File trytond/model/fields/property.py (right):

http://codereview.tryton.org/264001/diff/1/trytond/model/fields/property.py#newcode91
trytond/model/fields/property.py:91: 'AS SIGNED INTEGER), '\
Do we really need to cast here?
Could it be done in Python?

http://codereview.tryton.org/264001/diff/1/trytond/model/fields/property.py#newcode159
trytond/model/fields/property.py:159: sql_type = 'SIGNED INTEGER'
I would prefer to fix this cast mess of MySQL in the MySQL backend.

http://codereview.tryton.org/264001/diff/1/trytond/model/fields/property.py#newcode161
trytond/model/fields/property.py:161: sql_type = 'CHAR'
Should be already managed by MySQL backend.

http://codereview.tryton.org/264001/

--
[email protected] mailing list

Reply via email to