Reviewers: ,
Please review this at http://codereview.tryton.org/716003/ Affected files: M period.py Index: period.py =================================================================== --- a/period.py +++ b/period.py @@ -275,22 +275,23 @@ class Period(ModelSQL, ModelView): super(Period, cls).delete(periods) @classmethod def close(cls, periods): pool = Pool() JournalPeriod = pool.get('account.journal.period') Move = pool.get('account.move') - if Move.search([ - ('period', 'in', [p.id for p in periods]), - ('state', '!=', 'posted'), - ]): + unposted_periods = Move.search([ + ('period', 'in', [p.id for p in periods]), + ('state', '!=', 'posted'), + ]) + if unposted_periods: cls.raise_user_error('close_period_non_posted_move', - (period.rec_name,)) + (', '.join([p.rec_name for p in unposted_periods]),)) #First close the period to be sure #it will not have new journal.period created between. cls.write(periods, { 'state': 'close', }) journal_periods = JournalPeriod.search([ ('period', 'in', [p.id for p in periods]), ])