It replaces the simple 'select/option' HTML field by a combobox using a 
third party JQuery UI plugin (based on demo-version combobox in JQuery UI 
Documentation webpage).

It has some issues:
- the widget doesn't expand to all the container width
- the required background is in the container, not in the widget (and with the 
previous issue it looks wrong) [1]
- the on_change/on_change_with feature doesn't work

Provably, its interesting to do our own version of Combobox widget (based on 
that plugin) like is done by DateTime widget. And as its done in the plugin, 
generalize the autocompletion feature to be used in other widgets.

[1] as we talked, it would be great to move the "required" style 
definition from JS to CSS.
It should be done removing the background (color) definition done in JS 
(set_color()) by a class definition (something like 'required' or 
'sao-required') to the widget container, and the CSS sets the 
background color to the correct tag (it can change for each widget, what now is 
done by _get_color_el()).
It is more flexible (for example, it allow to fix the problem in combobox 
widget) and allows to change the 'required' background color in Themes.

URL: http://codereview.tryton.org/1641002/

Reply via email to