On 08 Dec 09:42, Simon Klemenc wrote: > sorry for putting this up top again, but from trying to contribute small > pieces and looking at other codereviews a thing that remains unclear to me > from howto contribute is pep8. > how should this be handled? When doing modifications on a file with pep8 > issues, should those issues be fixed with the patch?
No, you always provide unitary changesets. > or with a seperate patchset? Only if you fix them all. > or should they be remained for the future? That's the easy option. > (making the reviewbot sort of pointless and more annoying than anything > else) Not at all but the bot from time to time becomes more strict. -- Cédric Krier - B2CK SPRL Email/Jabber: cedric.kr...@b2ck.com Tel: +32 472 54 46 59 Website: http://www.b2ck.com/
pgpd_kkL5Daww.pgp
Description: PGP signature
