Jason van Zyl wrote:
>
> On 6/20/01 10:23 PM, "Daniel Rall" <[EMAIL PROTECTED]> wrote:
>
> > Boiled down from a discussion w/ jvz on IRC:
> >
> > Classes implementing a given piece of functionality that don't
> > absolutely need to be public (such as those which are only used
> > internally by that functionality), should provide only a package or
> > derivitative-accessible API (default or protected access for both
> > class and methods).
>
> I agree with this.
>
> +1
+1.
> So, for example, when I move the org.apache.turbine.util.upload.FileItem
> class I will put it in the org.apache.turbine.services.upload package
> instead of a separate util package within the service.
The problem with this particular one is that ParameterParser class
depends on
FileItem, and IIRC FileItem does not depend on UploadService internals,
o.a.t.util might be more appropriate home for it.
Rafal
--
Rafal Krzewski
Senior Internet Developer
mailto:[EMAIL PROTECTED]
+48 22 8534830 http://e-point.pl
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
