On 2/1/02 7:59 PM, "James Taylor" <[EMAIL PROTECTED]> wrote:
> I put together an implementation of some of the ideas I discussed > earlier, in the form of and abstract BaseConditionValve and two concrete > subclasses (request and extension based) that allow a set of valves to > be included or excluded based on conditions (implementation defined). > The mapper made this very easy! > > > I'm really happy with the way this turned out. It seems pretty elegant > considering no changes to existing pipeline classes were required. > Thoughts? Definitely cool, but I would like to leave the conditional aspects as optional so that in the case where you have an application that is using a single view type is optimized. I think your valves would also be very valuable for people migrating apps from jsp to velocity (no one would ever go the other way!) Does the pipeline you whipped up make jsp work with the classic model? That would be very cool if it does! John and I also briefly discussed a top-level selector, as I agreed with him when said he didn't like the idea of being able to select a pipeline with parameters. It would also be nice to be able to avoid the selector as well for say a pure velocity app so we can make things as optimal as possible. > Thanks, > James > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- jvz. Jason van Zyl http://tambora.zenplex.org http://jakarta.apache.org/turbine http://jakarta.apache.org/velocity http://jakarta.apache.org/alexandria http://jakarta.apache.org/commons -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
