Hi!

We made the transition from torque-2.1 to torque-3.0-dev in our project.
Unfortunately, we stumbled accross a newly introduced getter in BaseObject.java
named "getCategory()". This method collides with a column name "category" in
two of our tables.

Isn't the name "getCategory()" a bit too general and isn't the probability of
a name clash similar to ours a bit too high?

My suggestion would be to rename this method to "getLog4JCategory()" or some-
thing else.

As this is a developer list, a patch is attached.

Erich
-- 
Dr. Erich Meier, Software Process Improvement
method park, Wetterkreuz 19a, 91058 Erlangen, Germany
Tel. +49-9131-97206-316  mailto:[EMAIL PROTECTED]
Fax. +49-9131-97206-200  http://www.methodpark.de/
Index: src/java/org/apache/torque/om/BaseObject.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-turbine-torque/src/java/org/apache/torque/om/BaseObject.java,v
retrieving revision 1.7
diff -c -r1.7 BaseObject.java
*** src/java/org/apache/torque/om/BaseObject.java       19 Dec 2001 18:41:17 -0000     
 1.7
--- src/java/org/apache/torque/om/BaseObject.java       25 Feb 2002 12:51:24 -0000
***************
*** 415,421 ****
       *
       * @return a <code>Category</code> to write log to.
       */
!     protected Category getCategory()
      {
        return Category.getInstance(getClass().getName());
      }
--- 415,421 ----
       *
       * @return a <code>Category</code> to write log to.
       */
!     protected Category getLog4JCategory()
      {
        return Category.getInstance(getClass().getName());
      }

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to