> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: Sunday, March 17, 2002 11:32 PM
> To: [EMAIL PROTECTED]
> Subject: cvs commit:
> jakarta-turbine-torque/src/java/org/apache/torque/adapter DB.java
> 
> 
> dlr         02/03/17 23:32:22
> 
>   Modified:    src/java/org/apache/torque/adapter DB.java
>   Log:
>   Used getStringDelimiter() in getDateString(Date) (which should
>   probably be renamed to formatDate(Date)).
>   
>   Revision  Changes    Path
>   1.21      +3 -2      
> jakarta-turbine-torque/src/java/org/apache/torque/adapter/DB.java
>   
>   Index: DB.java
>   ===================================================================
>   RCS file: 
> /home/cvs/jakarta-turbine-torque/src/java/org/apache/torque/ad
> apter/DB.java,v
>   retrieving revision 1.20
>   retrieving revision 1.21
>   diff -u -u -r1.20 -r1.21
>   --- DB.java 15 Mar 2002 21:59:41 -0000      1.20
>   +++ DB.java 18 Mar 2002 07:32:22 -0000      1.21
>   @@ -90,7 +90,7 @@
>     * @author <a href="mailto:[EMAIL PROTECTED]";>Jon S. Stevens</a>
>     * @author <a href="mailto:[EMAIL PROTECTED]";>Brett McLaughlin</a>
>     * @author <a href="mailto:[EMAIL PROTECTED]";>Daniel Rall</a>
>   - * @version $Id: DB.java,v 1.20 2002/03/15 21:59:41 dlr Exp $
>   + * @version $Id: DB.java,v 1.21 2002/03/18 07:32:22 dlr Exp $
>     */
>    public abstract class DB implements Serializable, IDMethod
>    {
>   @@ -413,6 +413,7 @@
>                ts = new Timestamp(date.getTime());
>            }
>    
>   -        return "{ts '" + ts + "'}";
>   +        char delim = getStringDelimiter();
>   +        return ("{ts " + delim + ts + delim + '}');
>        }
>    }


I believe this is wrong. this is JDBC escape and not a DB-specific string,
so it should use what's specified in JDBC spec. (sorry :-) and that is
single quote and nothing else. Could you change it back, please?

thanks, 

Fedor.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to