You are right of course... This is what I get for using Eclipse instead of
a text editor.. Something i saw on another project was that they had Jalopy
integrated into their code base. Would it make sense to have something like
jalopy reformat source code that was saved with tabs? It seems like there
are some relatively non intrusive changes that could be integrated into the
build, or provide as part of a maven task..
so, when you edit your code, then do a maven "turbine:format" or something
and any inadvertant tabs or {} in the wrong place would be cleaned up...?
Eric
> -----Original Message-----
> From: McCombs, Quinton [mailto:[EMAIL PROTECTED]
> Sent: Friday, September 26, 2003 9:00 PM
> To: 'Turbine Developers List'
> Subject: RE: cvs commit:
> jakarta-turbine-2/src/java/org/apache/turbine/modules ActionEvent.java
>
>
> The established coding conversions explicitly state that
> spaces should be
> used instead of tabs.
>
> -----Original Message-----
> From: Angelo Turetta [mailto:[EMAIL PROTECTED]
> Sent: Friday, September 26, 2003 1:54 PM
> To: Turbine Developers List
> Subject: Re: cvs commit:
> jakarta-turbine-2/src/java/org/apache/turbine/modules ActionEvent.java
>
> ----- Original Message -----
> From: <[EMAIL PROTECTED]>
> Sent: Friday, September 26, 2003 7:54 PM
>
>
> > epugh 2003/09/26 10:54:09
> >
> > Modified: src/java/org/apache/turbine/modules/actions
> > VelocityAction.java
> > src/java/org/apache/turbine/modules ActionEvent.java
> > Log:
> > Actual code to deal with bubbling exceptions..
> >
> > Revision Changes Path
> > 1.6 +69 -59
> jakarta-turbine-2/src/java/org/apache/turbine/modules/actions/
> VelocityAction
> .java
> >
>
> After your commit, this is the result of building with maven:
>
> [javac] Compiling 417 source files to
> D:\Java\apache\jakarta-turbine-2\target\classes
> D:\Java\apache\jakarta-turbine-2\target\src\org\apache\turbine
> \modules\Actio
> nEvent.java:168: cannot resolve symbol
> symbol : variable ACTION_EVENT_BUBBLE_EXCEPTION_UP
> location: interface org.apache.turbine.TurbineConstants
>
> .getBoolean(TurbineConstants.ACTION_EVENT_BUBBLE_EXCEPTION_UP,
> ^
> D:\Java\apache\jakarta-turbine-2\target\src\org\apache\turbine
> \modules\Actio
> nEvent.java:169: cannot resolve symbol
> symbol : variable ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT
> location: interface org.apache.turbine.TurbineConstants
>
> TurbineConstants.ACTION_EVENT_BUBBLE_EXCEPTION_UP_DEFAULT);
> ^
>
>
> And, by the way, why don't you and Hennings please agree on the same
> formatting style? your commits strip spaces in favor of tabs, while
> Hennings' do exactly the opposite (which I personally prefer).
>
> Thanks for help.
> Angelo Turetta
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> *****
> "The information transmitted is intended only for the person
> or entity to
> which it is addressed and may contain confidential,
> proprietary, and/or
> privileged material. Any review, retransmission,
> dissemination or other use
> of, or taking of any action in reliance upon, this
> information by persons or
> entities other than the intended recipient is prohibited. If
> you received
> this in error, please contact the sender and delete the
> material from all
> computers.60"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
