Hi, If you get a chance, double check my commits.. Thanks for the conversion!
ERic > -----Original Message----- > From: Kostyantyn Shchekotykhin [mailto:[EMAIL PROTECTED] > Sent: Friday, November 12, 2004 5:21 PM > To: Turbine Developers List > Subject: AW: [REVOTE] Initial Release Fulcrum Components > > > Hi Eric, > Pleased to take a little from your plate :-) Thanks for your work. > I have merged splitted components: crypto, dvsl, factory, > localization, mimetype and pool. I removed all CVS info from > components dirs and hope that you will have no problems with > committing. All components where tested, and just localization failed: > test:test: > [junit] Running org.apache.fulcrum.localization.LocaleTokenizerTest > [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,491 sec > [junit] Running org.apache.fulcrum.localization.LocalizationTest > [junit] Tests run: 2, Failures: 0, Errors: 1, Time elapsed: 0,621 sec > [junit] [ERROR] TEST > org.apache.fulcrum.localization.LocalizationTest FAILED > > Because of "fail();" on line 88. If you will remove this call all > tests pass then. > > As dev list is not accepting zips i will send a copy on your email. > Regards, > Kostya > > > -----Urspr�ngliche Nachricht----- > > Von: Eric Pugh [mailto:[EMAIL PROTECTED] > > Gesendet: Freitag, 12. November 2004 11:19 > > An: Turbine Developers List > > Betreff: RE: [REVOTE] Initial Release Fulcrum Components > > > > Glad to get the +1.. I have been working on cleaning up some of the > > docs and adding the javadocs on. The initial reelease sites will have > > those docs. I will look through the issues you highlighted. > > > > The api/impl split was pioneered/required by using Merlin. > > Merlin wanted a seperate jar for each. However, not all the > > components where merlinized. I would actually like to merge them back > > together, but have enough on my plate. If someone wanted to spend a > > couple hours doing it, it would be much appreciated. > > > > Eric > > > > > -----Original Message----- > > > From: Scott Eade [mailto:[EMAIL PROTECTED] > > > Sent: Friday, November 12, 2004 2:59 AM > > > To: Turbine Developers List > > > Subject: Re: [REVOTE] Initial Release Fulcrum Components > > > > > > > > > > > > > > > > > >Vote: > > > >[X] +1 > > > >[ ] +1 (but not on all, please see comments below) [ ] +0 [ ] -1 > > > > > > > >Comments (I don't see any of the following as show stoppers): > > > > > > > * Is there some reason why some of the components are > > split between > > > an API and an Implementation in cvs (and project) but others > > > aren't? It just seems a little inconsistent. > > > * It would be great include the JavaDoc on the sites > > with a link to > > > it from the main pages (especially the empty ones), otherwise > > > there is often very little to see. > > > * bsf > > > o Usage information is actually for the GlobalCacheService > > > * cache > > > o Site hasn't been updated - last published 14 Feb 2004 > > > * dvsl > > > o No usage info (you could cheat by removing the heading). > > > * naming > > > o The link "this document" results in a 404. > > > * parser (not included in vote) > > > o Perhaps this should be moved under a different heading > > > ("Sandbox") > > > * template (not included in vote) > > > o Sandbox? > > > * testcontainer > > > o Perhaps this should be moved under a different heading > > > ("Testing components") > > > > > > Excellent stuff. > > > > > > Scott > > > > > > -- > > > Scott Eade > > > Backstage Technologies Pty. Ltd. > > > http://www.backstagetech.com.au > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
