I guess it would be a good idea to attach the patches...
Index: src/java/org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java,v
retrieving revision 1.4
diff -u -r1.4 DefaultSessionTimeoutValve.java
--- src/java/org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java
6 Dec 2004 17:47:11 -0000 1.4
+++ src/java/org/apache/turbine/pipeline/DefaultSessionTimeoutValve.java
10 Aug 2005 14:42:47 -0000
@@ -45,16 +45,14 @@
* Here we can setup objects that are thread safe and can be
* reused, so we get the timeout from the configuration..
*/
- public DefaultSessionTimeoutValve()
- throws Exception
+ public void initialize() throws Exception
{
- Configuration cfg = Turbine.getConfiguration();
+ super.initialize();
// Get the session timeout.
-
+ Configuration cfg = Turbine.getConfiguration();
timeout = cfg.getInt(SESSION_TIMEOUT_KEY,
- SESSION_TIMEOUT_DEFAULT);
-
+ SESSION_TIMEOUT_DEFAULT);
}
/**
Index: src/test/org/apache/turbine/pipeline/DefaultSessionTimeoutValveTest.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-2/src/test/org/apache/turbine/pipeline/DefaultSessionTimeoutValveTest.java,v
retrieving revision 1.5
diff -u -r1.5 DefaultSessionTimeoutValveTest.java
--- src/test/org/apache/turbine/pipeline/DefaultSessionTimeoutValveTest.java
6 Dec 2004 17:47:29 -0000 1.5
+++ src/test/org/apache/turbine/pipeline/DefaultSessionTimeoutValveTest.java
10 Aug 2005 14:43:10 -0000
@@ -115,6 +115,7 @@
Pipeline pipeline = new TurbinePipeline();
DefaultSessionTimeoutValve valve = new DefaultSessionTimeoutValve();
+ valve.initialize();
pipeline.addValve(valve);
pipeline.invoke(pipelineData);
@@ -137,6 +138,7 @@
Pipeline pipeline = new TurbinePipeline();
DefaultSessionTimeoutValve valve = new DefaultSessionTimeoutValve();
+ valve.initialize();
pipeline.addValve(valve);
pipeline.invoke(pipelineData);
Index: src/test/org/apache/turbine/util/BaseValueParserTest.java
===================================================================
RCS file:
/home/cvspublic/jakarta-turbine-2/src/test/org/apache/turbine/util/BaseValueParserTest.java,v
retrieving revision 1.6
diff -u -r1.6 BaseValueParserTest.java
--- src/test/org/apache/turbine/util/BaseValueParserTest.java 6 Dec 2004
17:47:32 -0000 1.6
+++ src/test/org/apache/turbine/util/BaseValueParserTest.java 10 Aug 2005
14:44:21 -0000
@@ -556,29 +556,29 @@
{
// no param
BigDecimal result = parser.getBigDecimal("invalid");
- assertEquals(new BigDecimal(0), result);
+ assertEquals(BigDecimal.valueOf(0), result);
// default
- result = parser.getBigDecimal("default", new BigDecimal(3));
- assertEquals(result, new BigDecimal(3));
+ result = parser.getBigDecimal("default", BigDecimal.valueOf(3));
+ assertEquals(result, BigDecimal.valueOf(3));
// param exists
parser.add("exists", "1");
result = parser.getBigDecimal("exists");
- assertEquals(result, new BigDecimal(1));
+ assertEquals(result, BigDecimal.valueOf(1));
// unparsable value
parser.add("unparsable", "a");
result = parser.getBigDecimal("unparsable");
- assertEquals(new BigDecimal(0), result);
+ assertEquals(BigDecimal.valueOf(0), result);
// array
parser.add("array", "1");
parser.add("array", "2");
parser.add("array", "3");
BigDecimal arrayResult[] = parser.getBigDecimals("array");
- BigDecimal compare[] = {new BigDecimal(1), new BigDecimal(2),
- new BigDecimal(3)};
+ BigDecimal compare[] = {BigDecimal.valueOf(1), BigDecimal.valueOf(2),
+ BigDecimal.valueOf(3)};
assertEquals(arrayResult.length, compare.length);
for( int i=0; i<compare.length; i++)
{
@@ -590,7 +590,7 @@
parser.add("array2", "a");
parser.add("array2", "3");
BigDecimal arrayResult2[] = parser.getBigDecimals("array2");
- BigDecimal compare2[] = {new BigDecimal(1), null, new BigDecimal(3)};
+ BigDecimal compare2[] = {BigDecimal.valueOf(1), null,
BigDecimal.valueOf(3)};
assertEquals(arrayResult2.length, compare2.length);
for( int i=0; i<compare2.length; i++)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
