Author: henning
Date: Mon Aug 29 06:54:40 2005
New Revision: 264141
URL: http://svn.apache.org/viewcvs?rev=264141&view=rev
Log:
Fix up a number of obvious minor problems and kinks found by Findbugs
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/om/security/peer/TurbineUserPeer.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/BooleanField.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/Field.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/validator/DefaultValidator.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/naming/TurbineNamingService.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/RelativeTemplateLink.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/TemplateLinkWithSlash.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUser.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUserManager.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueGroup.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorquePermission.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueRole.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueUser.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/xmlrpc/util/AuthenticatedFileHandler.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/DynamicURI.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/ObjectUtils.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/db/map/TurbineMapBuilder.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/mail/MailMessage.java
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/parser/BaseValueParser.java
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/om/security/peer/TurbineUserPeer.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/om/security/peer/TurbineUserPeer.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/om/security/peer/TurbineUserPeer.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/om/security/peer/TurbineUserPeer.java
Mon Aug 29 06:54:40 2005
@@ -300,7 +300,7 @@
}
if (value.isBoolean())
{
- obj2 = new Boolean(value.asBoolean());
+ obj2 = Boolean.valueOf(value.asBoolean());
}
if (value.isString())
{
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/BooleanField.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/BooleanField.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/BooleanField.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/BooleanField.java
Mon Aug 29 06:54:40 2005
@@ -54,7 +54,7 @@
return;
}
- defaultValue = new Boolean(prop);
+ defaultValue = Boolean.valueOf(prop);
}
/**
@@ -74,7 +74,7 @@
return;
}
- emptyValue = new Boolean(prop);
+ emptyValue = Boolean.valueOf(prop);
}
/**
@@ -163,7 +163,7 @@
}
else
{
- result = new Boolean(stringValue);
+ result = Boolean.valueOf(stringValue);
}
return result;
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/Field.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/Field.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/Field.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/model/Field.java
Mon Aug 29 06:54:40 2005
@@ -251,7 +251,7 @@
Rule reqRule = (Rule) field.getRuleMap().get("required");
if (reqRule != null)
{
- alwaysRequired = new Boolean(reqRule.getValue()).booleanValue();
+ alwaysRequired =
Boolean.valueOf(reqRule.getValue()).booleanValue();
ifRequiredMessage = reqRule.getMessage();
}
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/validator/DefaultValidator.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/validator/DefaultValidator.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/validator/DefaultValidator.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/intake/validator/DefaultValidator.java
Mon Aug 29 06:54:40 2005
@@ -104,7 +104,7 @@
if (constraint != null)
{
String param = constraint.getValue();
- required = new Boolean(param).booleanValue();
+ required = Boolean.valueOf(param).booleanValue();
requiredMessage = constraint.getMessage();
}
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/naming/TurbineNamingService.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/naming/TurbineNamingService.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/naming/TurbineNamingService.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/naming/TurbineNamingService.java
Mon Aug 29 06:54:40 2005
@@ -54,7 +54,7 @@
* A global Map of Property objects which are initialised using
* parameters from the ResourcesFile
*/
- private static Map contextPropsList = null;
+ private Map contextPropsList = null;
/** All initial contexts known to this service */
private Map initialContexts = new HashMap();
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/RelativeTemplateLink.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/RelativeTemplateLink.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/RelativeTemplateLink.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/RelativeTemplateLink.java
Mon Aug 29 06:54:40 2005
@@ -16,8 +16,6 @@
* limitations under the License.
*/
-import org.apache.turbine.services.pull.ApplicationTool;
-
/**
* This is exactly the same thing as TemplateLink but it returns a
* relative link on toString(). Everything else is identical. This class is
@@ -42,8 +40,6 @@
*/
public class RelativeTemplateLink
extends TemplateLink
- implements ApplicationTool
-
{
/**
* Default constructor
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/TemplateLinkWithSlash.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/TemplateLinkWithSlash.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/TemplateLinkWithSlash.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/pull/tools/TemplateLinkWithSlash.java
Mon Aug 29 06:54:40 2005
@@ -16,8 +16,6 @@
* limitations under the License.
*/
-import org.apache.turbine.services.pull.ApplicationTool;
-
/**
* This class allows one to specify paths in the setPage method
* using '/' slash as opposed to the ',' used in TemplateLink.
@@ -40,8 +38,6 @@
*/
public class TemplateLinkWithSlash
extends TemplateLink
- implements ApplicationTool
-
{
/**
* Default constructor
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/rundata/DefaultTurbineRunData.java
Mon Aug 29 06:54:40 2005
@@ -50,7 +50,6 @@
import org.apache.turbine.util.SystemError;
import org.apache.turbine.util.parser.CookieParser;
import org.apache.turbine.util.parser.ParameterParser;
-import org.apache.turbine.util.pool.Recyclable;
import org.apache.turbine.util.pool.RecyclableSupport;
import org.apache.turbine.util.security.AccessControlList;
import org.apache.turbine.util.template.TemplateInfo;
@@ -80,7 +79,7 @@
*/
public class DefaultTurbineRunData
extends RecyclableSupport
- implements TurbineRunData, Recyclable
+ implements TurbineRunData
{
/** The default locale. */
private static Locale defaultLocale = null;
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUser.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUser.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUser.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUser.java
Mon Aug 29 06:54:40 2005
@@ -77,7 +77,7 @@
createDate = new java.util.Date();
tempStorage = new Hashtable(10);
permStorage = new Hashtable(10);
- setHasLoggedIn(new Boolean(false));
+ setHasLoggedIn(Boolean.FALSE);
}
/**
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUserManager.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUserManager.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUserManager.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/ldap/LDAPUserManager.java
Mon Aug 29 06:54:40 2005
@@ -559,7 +559,7 @@
{
String host = LDAPSecurityConstants.getLDAPHost();
String port = LDAPSecurityConstants.getLDAPPort();
- String providerURL = new String("ldap://"; + host + ":" + port);
+ String providerURL = "ldap://"; + host + ":" + port;
String ldapProvider = LDAPSecurityConstants.getLDAPProvider();
String authentication = LDAPSecurityConstants.getLDAPAuthentication();
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueGroup.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueGroup.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueGroup.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueGroup.java
Mon Aug 29 06:54:40 2005
@@ -51,8 +51,7 @@
public class TorqueGroup
extends TorqueObject
implements Group,
- Comparable,
- Persistent
+ Comparable
{
/**
* Constructs a new Group.
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorquePermission.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorquePermission.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorquePermission.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorquePermission.java
Mon Aug 29 06:54:40 2005
@@ -38,8 +38,7 @@
public class TorquePermission
extends TorqueObject
implements Permission,
- Comparable,
- Persistent
+ Comparable
{
/**
* Constructs a Permission
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueRole.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueRole.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueRole.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueRole.java
Mon Aug 29 06:54:40 2005
@@ -42,8 +42,7 @@
public class TorqueRole
extends TorqueObject
implements Role,
- Comparable,
- Persistent
+ Comparable
{
/** The permissions for this role. */
private PermissionSet permissionSet = null;
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueUser.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueUser.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueUser.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/security/torque/TorqueUser.java
Mon Aug 29 06:54:40 2005
@@ -52,8 +52,7 @@
public class TorqueUser
extends TorqueObject
- implements User,
- Persistent
+ implements User
{
private static Log log = LogFactory.getLog(TorqueUser.class);
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/xmlrpc/util/AuthenticatedFileHandler.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/xmlrpc/util/AuthenticatedFileHandler.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/xmlrpc/util/AuthenticatedFileHandler.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/services/xmlrpc/util/AuthenticatedFileHandler.java
Mon Aug 29 06:54:40 2005
@@ -67,7 +67,7 @@
{
if (method.equals("send"))
{
- obj = new Boolean(this.send((String) params.elementAt(0),
+ obj = Boolean.valueOf(this.send((String) params.elementAt(0),
(String) params.elementAt(1),
(String) params.elementAt(2)));
}
@@ -82,12 +82,12 @@
{
AuthenticatedFileHandler.remove((String) params.elementAt(0),
(String) params.elementAt(1));
- obj = new Boolean("true");
+ obj = Boolean.TRUE;
}
}
else
{
- obj = new Boolean("false");
+ obj = Boolean.FALSE;
}
return (Object) obj;
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/DynamicURI.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/DynamicURI.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/DynamicURI.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/DynamicURI.java
Mon Aug 29 06:54:40 2005
@@ -411,7 +411,7 @@
*/
public DynamicURI addPathInfo(String name, int value)
{
- add(PATH_INFO, name, new Integer(value).toString());
+ add(PATH_INFO, name, String.valueOf(value));
return this;
}
@@ -424,7 +424,7 @@
*/
public DynamicURI addPathInfo(String name, long value)
{
- add(PATH_INFO, name, new Long(value).toString());
+ add(PATH_INFO, name, String.valueOf(value));
return this;
}
@@ -489,7 +489,7 @@
*/
public DynamicURI addQueryData(String name, int value)
{
- add(QUERY_DATA, name, new Integer(value).toString());
+ add(QUERY_DATA, name, String.valueOf(value));
return this;
}
@@ -502,7 +502,7 @@
*/
public DynamicURI addQueryData(String name, long value)
{
- add(QUERY_DATA, name, new Long(value).toString());
+ add(QUERY_DATA, name, String.valueOf(value));
return this;
}
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/ObjectUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/ObjectUtils.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/ObjectUtils.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/ObjectUtils.java
Mon Aug 29 06:54:40 2005
@@ -166,14 +166,9 @@
{
in.close();
}
- if (bufin != null)
- {
- bufin.close();
- }
- if (bin != null)
- {
- bin.close();
- }
+
+ bufin.close();
+ bin.close();
}
catch (IOException e)
{
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/db/map/TurbineMapBuilder.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/db/map/TurbineMapBuilder.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/db/map/TurbineMapBuilder.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/db/map/TurbineMapBuilder.java
Mon Aug 29 06:54:40 2005
@@ -639,7 +639,7 @@
TableMap tMap;
// Make some objects.
- String string = new String("");
+ String string = "";
Integer integer = new Integer(0);
java.util.Date date = new Date();
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/mail/MailMessage.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/mail/MailMessage.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/mail/MailMessage.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/mail/MailMessage.java
Mon Aug 29 06:54:40 2005
@@ -534,7 +534,7 @@
}
else
{
- debug = new Boolean(str).booleanValue();
+ debug = Boolean.valueOf(str).booleanValue();
}
}
Modified:
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/parser/BaseValueParser.java
URL:
http://svn.apache.org/viewcvs/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/parser/BaseValueParser.java?rev=264141&r1=264140&r2=264141&view=diff
==============================================================================
---
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/parser/BaseValueParser.java
(original)
+++
jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/parser/BaseValueParser.java
Mon Aug 29 06:54:40 2005
@@ -86,7 +86,7 @@
*/
public class BaseValueParser
extends RecyclableSupport
- implements ValueParser, Recyclable
+ implements ValueParser
{
/** Logging */
private static Log log = LogFactory.getLog(BaseValueParser.class);
@@ -477,7 +477,7 @@
*/
public Boolean getBool(String name, boolean defaultValue)
{
- return getBooleanObject(name, new Boolean(defaultValue));
+ return getBooleanObject(name, Boolean.valueOf(defaultValue));
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
