Siegfried Goeschl wrote:
Henning P. Schmiedehausen wrote:

[EMAIL PROTECTED] writes:

+    /** the name of the subversion metadata directory */
+    private static final String SVN_DIRNAME = ".svn";
+
-                if( list[i].isDirectory() )
+ // skip the subversion directories otherwise we pick

Does this make sense? As we can be quite sure that noone will ever
repeat the "CVS" mistake, why not use

list[i].isHidden()

I think this is wrong for more than this reason.

Is the fulcrum-resourcemanager intended as a general-purpose service? So why should you have such a hack in the code? What if some user need to keep their resource files in a directrory called .svn?

This is actually a problem in the test code itself. If the test suite needs to work on a clean resource tree, copy the files from src/test/resources somewhere under target, skipping everything you don't need, then run the test pointing the repository to the clean tree.

Otherwise the only clean way of skipping a directory is by adding configuration options like ant's "exclude/include" and let the user specify what to consider part of their repository.

Angelo Turetta.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to