Author: seade Date: Fri Jun 23 00:07:07 2006 New Revision: 416586 URL: http://svn.apache.org/viewvc?rev=416586&view=rev Log: Attempt at a test case to highlight the NPE identified by TRB-8.
Modified: jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java Modified: jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java URL: http://svn.apache.org/viewvc/jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java?rev=416586&r1=416585&r2=416586&view=diff ============================================================================== --- jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java (original) +++ jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java Fri Jun 23 00:07:07 2006 @@ -25,6 +25,8 @@ import org.apache.turbine.services.TurbineServices; import org.apache.turbine.test.BaseTestCase; import org.apache.turbine.util.ServerData; +import org.apache.turbine.util.parser.DefaultParameterParser; +import org.apache.turbine.util.parser.ParameterParser; import org.apache.turbine.util.parser.ParserUtils; /** @@ -139,6 +141,31 @@ turi.addPathInfo("test", null); assertEquals("/context/servlet/turbine/test/null", turi.getRelativeLink()); turi.removePathInfo("test"); + assertEquals("/context/servlet/turbine", turi.getRelativeLink()); + } + + public void testAddEmptyParameterParser() + { + ParameterParser pp = new DefaultParameterParser(); + turi.add(1, pp); // 1 = query data + assertEquals("/context/servlet/turbine", turi.getRelativeLink()); + } + + public void testAddParameterParser() + { + ParameterParser pp = new DefaultParameterParser(); + pp.add("test", ""); + turi.add(1, pp); // 1 = query data + assertEquals("/context/servlet/turbine?test=", turi.getRelativeLink()); + turi.removeQueryData("test"); + assertEquals("/context/servlet/turbine", turi.getRelativeLink()); + + pp = new DefaultParameterParser(); + pp.add("test", (String) null); + turi.add(1, pp); // 1 = query data + // Should make the following work so as to be consistent with directly added values. + //assertEquals("/context/servlet/turbine?test=null", turi.getRelativeLink()); + turi.removeQueryData("test"); assertEquals("/context/servlet/turbine", turi.getRelativeLink()); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]