I think it is fine now. It is hard to make unit tests for the other auxiliaries. You pretty much need two jvms. . . .
With the disk cache working again, the memory usage should be improved as well. I thought there was an original cap on the number of event threads that could be running. It did in some version a long time ago. The complexity of the old queue makes it hard to track. The FIFO queue there now is simple and easy to understand. It should be just fine. If there is no cap on the event threads, you can overrun the remote server with events. The retry will catch most of these issues though. I'm going to continue cleaning the element event stuff. I'm going to comment out non supported events and only allow for background event handling. The standard event handler will no longer have a return value, or I will leave it and type the events and handlers. Foreground type handlers will be able to return values, maybe. . . . For now all events will be handled in the background queue. A single handler can handle as many types of events as it likes. . . . This should meet most event handling needs. Aaron > -----Original Message----- > From: James Taylor [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, May 14, 2002 11:46 AM > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: jakarta-turbine- > jcs/src/java/org/apache/jcs/engine CacheEventQueue.java > > > This had an awful bug. All the events were getting sent into the Q > and getting nullified. > > Nice catch! > > > The only reason the disk cache seemed to work was because of the > purgatory. > > That seems reasonable. Looks like we NEED MORE UNIT TESTS! =] > > I'll try to code up a decent unit test for the event queue. > > > This is one of the most central classes in the entire system. It has > been messed with a lot because it used to use JGL stuff. > > Yup, it was using the queue from util.concurrent but that was too slow. > This implementation is pretty much as fast as possible (even after the > bug fix =) > > > I guess this does everything the old Q used to do. I'm not sure. > > It should. > > > > > -- > To unsubscribe, e-mail: <mailto:turbine-jcs-dev- > [EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:turbine-jcs-dev- > [EMAIL PROTECTED]>
