It was AMAZINGLY easy to make this change (PooledExecutor with a BoundedBuffer, as you suggested). I'd like to submit it to the experimental package for testing...
But I'm (still) having a problem with my commit access. When I try to commit, I get 'pre-commit check failed'. Erik Abele has been very patient with me in explaining that this is because the PMC has not added me the relevant line in /x1/home/cvs/CVSROOT/avail on cvs.apache.org. Who should I next contact to get this resolved? -Travis Savo <[EMAIL PROTECTED]> -----Original Message----- From: Aaron Smuts [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 20, 2004 8:26 PM To: 'Turbine JCS Developers List' Subject: RE: EventQueues and Threads Your implementation works nicely, but we can change it and make it more configurable. It should probably use the PooledExecutor with a BoundedQueue, set to runincurrentthread or discard oldest when full. The size of the queue and the number of min threads, the idle life, and the max should be configurable in the cache.ccf. The admin package I mentioned will help here. . . . Aaron > -----Original Message----- > From: Travis Savo [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 20, 2004 7:16 PM > To: 'Turbine JCS Developers List' > Subject: EventQueues and Threads > > We discussed in the past a Thread Throttle to limit the number of Threads > for EventQueues. > > Really I think the right solution is a Thread Pool, (and/or a Runnable > Queue). If we convert the EventQueue to a Runnable and pull threads from > the > pool as they become available (and/or stick the Runnables in a queue for > processing, either way we achieve the same effect: The threads, of which > there are a limited number, get reused), this eliminates the need for a > throttle, and makes much better reuse of Threads, so 'keeping it alive for > a > minute' is no longer necessary: The life of the unused Thread itself can > be > handled by the Pool. > > Does this sound like the right solution to you? Or at least headed in the > direction of the right solution? > > I just wanted to check with you before I start down a path that won't lead > to everyone's consent. > > -Travis Savo <[EMAIL PROTECTED]> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
