Hi Tom,

Thanks for the patch. Don't you think it would be cleaner if we simply
make a check as to whether the maven.cactus.webxml property is defined
as in:

If maven.cactus.webxml not define then
  Define maven.cactus.webxml

Actually, I'm not sure I understand how the patch works or how you use
the plugin. I understand that you define maven.cactus.webxml in your
project.properties, is that correct? It seems to me that the patch will
not use that property any more for packaging the war... Am I wrong here?

Thanks
-Vincent


> -----Original Message-----
> From: Tom Palmer [mailto:tomp@;uk.uu.net]
> Sent: 23 October 2002 14:21
> To: '[EMAIL PROTECTED]'
> Subject: [Patch] Fix cactus so that maven.cactus.webxml can be
overridden
> 
> Hi,
> 
>   The attached patch alters the cactus plugin so that the property
> maven.cactus.webxml can be overridden allowing the user to supply a
custom
> web.xml file for the cactus WAR (especially important if you are using
the
> cactus plugin to test EJB's).
> 
>   This will restore the behaviour of revision 1.2 of
> src/plugin-builds/cactus/scripts/tomcat.4x.jelly. Note that the patch
> SHOULD
> work but I haven't tested that it keeps the desired behaviour of
revision
> 1.3 (it does fix my case above).
> 
>   Regards,
> 
>   Tom



--
To unsubscribe, e-mail:   <mailto:turbine-maven-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:turbine-maven-dev-help@;jakarta.apache.org>

Reply via email to