> -----Original Message----- > From: Adrian Sutton [mailto:[EMAIL PROTECTED]] > Sent: 1. desember 2002 22:19 > To: Turbine Maven Users List > Subject: Re: Recent windows batch file changes > > > > I have submitted a patch for maven/maven.bat that should fix it: > > http://jira.werken.com/secure/ViewIssue.jspa?key=MAVEN-166 > > From that issue: > > This patch adds the functionality to discover the jdk version. This > > is done by looking for the directory %JAVA_HOME%\jre\bin\client which > > only exists (I think) on j2sdk1.4.1. If the directory exists, the > > XML/Xerces related parameters are not passed to the VM. > > This is rather concerning. There is no requirement for that file to > exist (nor the entire %JAVA_HOME%\jre directory) in a Java 1.4 SDK. > This patch wouldn't work on those systems. It would probably be > better to assume that the version of the JDK is the same as the JRE and > just use java.version and check to see if it's greater than 1.4. >
You're right. It would be better if the XML related System properties were set in org.apache.maven.cli.App, based on the java.version system property. > > Aslak > > Thanks for all the good work you maven people are doing though. :) > Hey, I'm just a user ;-) Aslak > Adrian Sutton. > > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
