Hello, Diez!

Thank you very much! It fixed the bug.

The patch is now applied 
<http://code.google.com/p/tgtools/source/detail?r=106> so we're getting 
closer! :)

Cheers.

On Thursday October 23, 2008 23:24:25 Diez Roggisch wrote:
> Hi,
>
> I fixed that - see the attached patch.
>
> In a nutshell, the problem was that you didn't keep a reference to the
> group-object around, so that it's state was garbage-collected. I created a
> reference - and the problem went away.
>
> HTH,
>
> Diez
>
> -----Ursprüngliche Nachricht-----
> Von: "Gustavo Narea" <[EMAIL PROTECTED]>
> Gesendet: 23.10.08 22:01:30
> An: TurboGears Trunk <[email protected]>
> Betreff: [tg-trunk] Re: Status of tgext.authorization - Help needed
>
> On Wednesday October 22, 2008 00:31:55 Gustavo Narea wrote:
> > 1.- If somebody who knows SQLAlchemy could take a look into the SQL
> > plugin, the problem with the session would be solved: Those actions that
> > insert, update or delete rows don't get applied. I can't find the
> > problem, but I'm sure it is something small and stupid. As a hint, the
> > files to look into are: The plugin itself
> > <http://code.google.com/p/tgtools/source/browse/projects/tgext.authorizat
> >io n/trunk/tgext/authorization/plugins/sql.py>, databasesetup.py
> > <http://code.google.com/p/tgtools/source/browse/projects/tgext.authorizat
> >io n/trunk/tests/databasesetup.py> and possibly the model
> > <http://code.google.com/p/tgtools/source/browse/projects/tgext.authorizat
> >io n/trunk/tests/fixture/model.py>. You may run the tests (`nosetests`) to
> > find the problems I'm talking about. This is not a blocker issue, but
> > it'd be great if it gets fixed before start using this extension.
>
> I fixed all of those errors, except one. I'd really appreciate if somebody
> could check _BaseSqlAdapter._include_items() in
> http://code.google.com/p/tgtools/source/browse/projects/tgext.authorization
>/trunk/tgext/authorization/plugins/sql.py
>
> Otherwise I'll take care of that after the TG2 b1, so that I can work on
> the pending stuff.
>
> > 2.- Both authorize.has_all_permissions() and
> > authorize.has_any_permission() are broken according to the tests; the
> > other similar functions work perfectly. I've already asked Florent to
> > help me out with this, but if somebody else wants to help would be great.
> > I'm sure the problem here is stupid too, but I've not been able to spot
> > it. As a hint, the files to look into are: test_controller_security.py
> > <http://code.google.com/p/tgtools/source/browse/projects/tgext.authorizat
> >io n/trunk/tests/test_controller_security.py> (the tests for authorize.*)
> > and base.py
> > <http://code.google.com/p/tgtools/source/browse/projects/tgext.authorizat
> >io n/trunk/tests/base.py> (where the
> > mock users/groups/permissions are created, as well as the WSGI app used
> > in the tests). If you run the tests you'll find the two failures I'm
> > talking about (in test_controller_security.py).
>
> This is the only blocker issue and tonight I'll make another try to fix it.
>
> > 3.- Integrate the extension in the default template. I've already started
> > a branch for this, to avoid breaking the trunk, and should be finished
> > quickly.
>
> This is done but I'm going to test it further before merging the branch in
> the trunk.
>
> On the other hand, the auth docs are around ~65% complete.
>
> Cheers.

-- 
Gustavo Narea.
http://gustavonarea.net/

Get rid of unethical constraints! Switch to Freedomware:
http://softwareliberty.com/


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"TurboGears Trunk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/turbogears-trunk?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to