Evelind,

Looks great!  I am +1 on Michele's suggestion to call it FeedController.
Also, "Entrys" should probably be "Entries"?

What do you think about making the title, link, description and such
attributes like:

class MyFeed(Feed):
    title = "My Simple Feed"
    link = "http://www.example.com/feed";
    description = "This is my really simple feed."

    def items(self):
        # ... return list of feed entry dict's here
    

My only reason to suggest this is to break up get_feed_data into logical
parts so you don't have one monolithic function to generate a feed.  If
anyone needs to run code to determine the feed title / link / etc at
runtime, they can use properties.


Sean Cazzell






On Sat, 2005-11-12 at 10:32 +0100, Elvelind Grandin wrote:
> With version 0.9 turbogears will support easy generating of rss/atom feeds.
> There still some stuff to add like knowledge of wich elements are valid etc.
> But here is a quicklook at how it looks like now.
> http://trac.turbogears.org/turbogears/wiki/FeedObject#preview
> 
> Any suggestions on features or syntax are more than welcome
> 
> 
> --
> cheers
>     elvelind grandin

Reply via email to