On Tue, 2005-11-15 at 16:34 -0600, Ian Bicking wrote:
> I think "expected" exceptions (including redirects) should not roll back 
> the transaction.  Unexcepted exceptions (everything else should). 
> However, you should be able to explicitly roll back or commit the 
> transaction if the decorator doesn't do what you want.

See, I knew I was forgetting something.  I wonder what a reasonable list
of "expected exceptions" that we don't rollback on is?  It should
probably be short, I don't want to not rollback if someone is expecting
it.  I agree with Ian on:

cherrypy.HTTPRedirect

What about:

cherrypy.NotFound
cherrypy.HTTPError
cherrypy.InternalRedirect

I think we should include InternalRedirect and not the other two.  The
list of cherrypy errors can be found in _cperror.py.


Sean Cazzell

Reply via email to