Thanks for the input!
> - hub.commit() is left as a little bit of unexplained black magic. You
> might want to consider explaining in a sentence or two what the hub is.
> I didn't find it incredibly obvious from looking at the other TG docs
> so a mention here might be helpful.
Done!
> - l1 is not a great variable name ;) I can imagine someone somewhere
> scratching their head because they typed the wrong thing. Maybe list1
> would be better as it's more obvious what it represents. The same
> happens later with "for l in user.lists" which may look like "for 1 in
> user.lists" in some typefaces and confuse unwary programmers new to
> Python.
Yeah, coming up with ways to not shadow 'list' sucks. I changed it to
theList or userList where appropriate. (If you can think of better
names let me know.)
> - I was under the impression that "raise
> cherrypy.HTTPRedirect('index')" was superceded by
> "turbogears.redirect('index')" from 0.9 onwards, though I am not too
> familiar with 0.9 and there may be subtle differences I don't know
> about?
That's news to me. I changed it.
> - In parts of the tutorial where source is repeated from above, would
> it be possible to shade the new lines differently to highlight what is
> added at each stage?
I wanted that too, but I don't think there is a way to do it with
reStructuredText. If someone knows otherwise, let me know. I tweak the
text source often so I don't want to have to go and modify the HTML
every time...
--
Brian Beck
Adventurer of the First Order
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"TurboGears" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/turbogears
-~----------~----~----~----~------~----~------~--~---
