1.0, 1.5 and presumably 1.1 (although I can't find the docs for this
in 1.1 and have never used it myself) have an issue...

See:
http://docs.turbogears.org/1.0/ErrorReporting
http://docs.turbogears.org/1.5/ErrorReporting

It's also present in the example project for 1.0.

The line

log.exception("CherryPy %s error (%s) for request '%s'", status,
error_msg, url)

needs to read:

log.exception("CherryPy %s error (%s) for request '%s'" % (status,
error_msg, url))

Although while we are fixing it I think we should change it to
something like this:

   user_agent = cherrypy.request.headers.get("User-Agent", "")
   log.exception("CherryPy %s error (%s) for request '%s'\n  (User-
Agent: %s)\n" % (
                status, str(error_msg), url, user_agent))

I find having the user-agent extremely useful in debugging  what
caused the error.

I'm guessing since it went undiscovered so long that almost no one
uses this.  Which is a shame, because it's super useful.

If we're going to do a TG 1.6 - I think it would be great to have
catch all error-reporting as an option in the quickstart, just like
identity. I could maybe find time to make a go at it - if everyone
thinks it's a great idea - and a TG 1.6 is actually going to be made.

-Sam



-- 
You received this message because you are subscribed to the Google Groups 
"TurboGears" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/turbogears?hl=en.

Reply via email to