On Jan 13, 2006, at 9:55 AM, Jeremy Boynes wrote:
Jean-Sebastien Delfino wrote:
- I think we need to establish a policy that the build should never
break and in particular the acceptance test suite should run
before each
commit. The sooner we get a stable build the sooner all of us can
engage with all the work we have ahead of us.
I thought we split these to allow some stuff to break temporarily.
IOW, normal unit/integration tests would run automatically as part
of a
normal build and were supposed to work for every commit. The goal
is to
produce a build that is "good enough" for the developers to work
with -
i.e. the default build works every time, no excuses.
I tend to agree with Jeremy, particularly when we get to deploying on
other platforms besides Tomcat, since running all of the acceptance
tests would be unwieldy (and also assumes I have Tomcat set up). It
seems like what we need to do is have better unit test coverage to
check this type of stuff. For example, the
TomcatServerLifecycleListener is not referenced or unit tested so the
core build doesn't break, even though it is critical.
The acceptance tests were meant to replicate scenarios users would see
and were meant to be run before any release/distribution e.g. before
posing an "unstable" build somewhere. Eventually these would grow
(e.g.
to include compliance tests) and take so long to run that it would be
impractical to run them for every commit.
--
Jeremy
