I thought we were going to change the composite target invokers to be like interceptors that when they were invoked would "flip" the message from the composite reference inbound/outbound pair to the target service's inbound/outbound chain? I also was thinking the invokers should not inherit from Pojo invoker or use reflection since pojos aren't necessarily involved, even for local invocations.

Jim

On Sep 30, 2006, at 6:10 AM, Ignacio Silva-Lepe wrote:

Ok, I took a look. Fixing CompositeReference to not be interface/ method centric is not a big deal. However CompositeReferenceTargetInvoker and CompositeReferenceCallbackTargetInvoker are defined in terms of PojoTargetInvoker which itself is interface/method centric. Given the current architecture, and the fact that CompositeReference and CompositeService are intended for local use, it seems fair to assume a dependency on PojoTargetInvoker.

If this is the case, then the fix will not work because WSDLServiceContract for instance, even though it extends ServiceContract, does not set its interfaceClass or callbackClass, hence the NPE. So, under this assumption, either WSDLServiceContract would need to set its interfaceClass and callbackClass (which seems hard to do), or CompositeReference and CompositeService, which represent bindless reference and service respectively, should not use WSDLServiceContract, i.e., bindless references and services should not use <interface.wsdl>.

If this is not the case, for which would it be interesting to see the justification, then a different way of invoking CompositeReferences and CompositeServices would need to be used, one that does not rely on java reflection.

Thoughts?

----- Original Message -----
From: "Raymond Feng (JIRA)" <tuscany-dev@ws.apache.org>
To: <tuscany-dev@ws.apache.org>
Sent: Friday, September 29, 2006 6:25 PM
Subject: [jira] Commented: (TUSCANY-767) NPE in CompositeReference.java when service is defined using interface wsdl


[ http://issues.apache.org/jira/browse/TUSCANY-767? page=comments#action_12438820 ]

Raymond Feng commented on TUSCANY-767:
--------------------------------------

Ignacio, it seems that the CompositeReference code was initially contributed by you, can you take a look? I found this class is still java interface/method centric and cannot handle WSDL portType/operation.

Thanks,
Raymond

NPE in CompositeReference.java when service is defined using interface wsdl -------------------------------------------------------------------- -------

                Key: TUSCANY-767
URL: http://issues.apache.org/jira/browse/ TUSCANY-767
            Project: Tuscany
         Issue Type: Bug
         Components: Java SCA Core
   Affects Versions: Java-M2
           Reporter: Rick Rineholt
           Priority: Blocker
            Fix For: Java-M2


If a service is defined using interface wsdl the service contract does not have an interface class this results in org.apache.tuscany.core.implementation.composite.CompositeReference getting an NPE.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/ Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/ software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to