[ 
https://issues.apache.org/jira/browse/TUSCANY-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473108
 ] 

Kelvin Goodson commented on TUSCANY-713:
----------------------------------------

Hi Yang,
I seem to have a problem with the ProcessSchemaLocations.713 file that you 
supplied.  The patch application file complains about line 55,  so I began 
applying the patch manually.  I have a couple of requests,  one trivial request 
is that you use the .patch extension for patches,  and if you could make them 
from a lower point in the directory hierarchy it would save me having to remove 
the java/sdo prefix from all the markup lines inside the patch (since these 
days I only usually check out at the sdo level for applying patches) .  The 
other point which is specific to this patch is the use of bulk imports via the 
wildcard import statement.  I don't know if we have a policy on this in 
general,  but I think its better practice to import only what's required.  
However, in this case its more of an issue, since you have now introduced an 
implicit import of a class from EMF that has a well known synonym in Tuscany,  
namely XMLHelperImpl.  I think it's particularly important to be specific about 
which classes are imported when there are two classes of the same name.  Could 
you please supply a fixed up patch file and I will get this out of the way,  
thanks.
Kelvin.


> Discover and regiester new SDO types during the time of loading the XML 
> instance document
> -----------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-713
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-713
>             Project: Tuscany
>          Issue Type: New Feature
>          Components: Java SDO Implementation
>    Affects Versions: Wish list
>            Reporter: Fuhwei Lwo
>             Fix For: Wish list
>
>         Attachments: ProcessSchemaLocations.713, SchemaLocationTestCase.java, 
> SchemaLocationTestCase.java, SchemaLocationTestCase.xml, SDOUtil.java
>
>
> Current SDO implementation requires one to register the SDO types before 
> loading their instances from XML document.  The new scenario is to load the 
> XML document before registering the types.  The SDO may require the XML 
> document to provide some information to locate its schema or metadata 
> location.  Annotation may be one way to do it. The schemaLocation attribute 
> is not sufficient because it's only a hint not necessarily a physical 
> location.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to