Thanks Adriano for helping reviewing some of the patches...
I also noticed that there was no unit tests on the patch (at least on the
latest one). I think we should really encourage the submission of unit tests
along with patches that are improvements to existing features or new
features.
---------- Forwarded message ----------
From: Adriano Crestani (JIRA) <tuscany-dev@ws.apache.org>
Date: Apr 25, 2007 12:32 AM
Subject: [jira] Commented: (TUSCANY-952) DAS must support queries that
reference tables in different "schemas"
To: tuscany-dev@ws.apache.org
[
https://issues.apache.org/jira/browse/TUSCANY-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491540]
Adriano Crestani commented on TUSCANY-952:
------------------------------------------
I don't know if I'm correct, but the condition in the method below shouldn't
be the inverse?
Actually:
public void addConverter(String name, String converter) {
QualifiedColumn column = new QualifiedColumn(name);
Table t = null;
if(this.config.isDatabaseSchemaNameSupported()){
t = findOrCreateTable(column);
}
else{
t = findOrCreateTable(column.getSchemaName(),
column.getTableName());//JIRA-952
}
Column c = findOrCreateColumn(t, column.getColumnName());
c.setConverterClassName(converter);
}
Suggested:
...
if(this.config.isDatabaseSchemaNameSupported()){
t = findOrCreateTable(column.getSchemaName(),
column.getTableName());//JIRA-952
}
else{
t = findOrCreateTable(column);
}
...
(Sorry for the indentation, but it's difficult to indent code on these
comments :s)
Cause there is only schema name if the database schema name is supported.
Adriano Crestani
DAS must support queries that reference tables in different "schemas"
---------------------------------------------------------------------
Key: TUSCANY-952
URL: https://issues.apache.org/jira/browse/TUSCANY-952
Project: Tuscany
Issue Type: Bug
Components: Java DAS RDB
Reporter: Kevin Williams
Fix For: Java-DAS-Mx
Attachments: DAS-JIRA-952-Apr24-Amita.txt, JIRA-952-Details.doc,
JIRA-952-Feb16-Amita.jar, JIRA-952-Mar01-Amita.jar
The DAS is curently ignorant of database schema designations. This means
the DAS will generate incorrect write statements when it processes the
change summary from a data graph that originated from a query that uses
schema names that are different from the default schema.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Luciano Resende
http://people.apache.org/~lresende
