[
https://issues.apache.org/jira/browse/TUSCANY-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493372
]
Kelvin Goodson commented on TUSCANY-1241:
-----------------------------------------
Brian, thanks for this. I have had a good look at the changes you are
proposing. Most of the stuctural changes are in line with what I have already
put in place.
You will see that I have deprecated BaseSDOParametizedTest class in favour of
the new ParameterizedTestBase.
As you pointed out, this update comes at a time when there is much change and
much discussion about further change, including the suggestion of not using
the junit 4.1 parameterized testing feature, and providing similar behaviour
where required through java features alone. I'm in favour of this latter
approach, so I think we need to work out a staged way of getting to that
position without losing useful updates.
I took a detailed look at the first dozen or so of your classes and I think
that the best approach may be for me to judiciously apply your changes as they
are here as much as and as best as I can. I will retain the
BaseSDOParameterizedTest as the superclass for all test cases other than the
two that I have already moved to be specializations of ParameterizedTestBase.
We can then work out whether we move away from the deprecated base class by
converging on the new ParameterizedTestBase or whether we work towards removing
the reliance upon the junit parameterized feature.
By the way, I can't see where the CategorizedParameterized runner comes from
yet. Is this something or yours that is missing from the patch?
> Provide CTS Updates for HelperContext and a new DO creation mechanism
> ---------------------------------------------------------------------
>
> Key: TUSCANY-1241
> URL: https://issues.apache.org/jira/browse/TUSCANY-1241
> Project: Tuscany
> Issue Type: Test
> Components: Java SDO Implementation
> Reporter: Brian Murray
> Priority: Minor
> Attachments: cts.patch, cts.patch
>
>
> My team has been using a separate branch of the CTS, and we have made some
> updates. I'd like to provide those changes back to Tuscany. Those changes
> include test case corrections and additions, the use of HelperContext, and
> the use of a new DataObjectFactory class . The DataObjectFactory class has
> Method and Object[] members that are populated via the constructor. The
> class has methods with void parameter lists to create different Types of
> DataObjects relevant to the test cases. In this way, the individual test
> cases need not be aware of the creation or definition mechanism of the
> DataObject being tested.
> I am opening this Jira simply as a mechanism to provide the patch containing
> our changes. (So that I may provide the required usage agreements with the
> patch.)
> Note that the patch is not complete. However, I'm aware that discussion has
> picked up and I want to provide my changes as quickly so as to avoid
> unnecessary merging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
