Thanks Simon. Let me go fix these things. Will call out for help when needed. :) - Venkat
On 7/2/07, Simon Laws <[EMAIL PROTECTED]> wrote:
On 6/29/07, ant elder <[EMAIL PROTECTED]> wrote: > > On 6/28/07, Venkata Krishnan <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > Please review and vote on the 0.91 release artifacts of Tuscany SCA for > > Java. > > > > The artifacts are available for review at: > > http://people.apache.org/~svkrish/tuscany/0.91-rc1/ > > > > The SVN tag for the release is: > > > > > https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/0.91-rc1-incubating/ > > > > Seems ok to me, so here is my +1. > > > > Thanks. > > > > - Venkat > > > > +1 > > This looks pretty good to me. There's a few things that could be improved > - > missing readme's for demos and some samples, some missing license headers > have crept in, the rmi calculator client fails for me - none of those are > blocking problems though. The biggest is for 0.90 we were asked to list > all > the jars under the Apache license just to make the licensing clear but > thats > missing, again not a blocker but it would be good to show we listen. I'll > try to fix most of these in the brn in case we do cut another rc, but > unless > many more problems are discovered this rc gets my vote. > > ...ant Apologies for being so late to review the RC. Was away last week. Anyhow... I got a clean build of the source distro. I went through the samples in the bind distro. The issues I found are attached below. Ant, I'm assuming you have fixed many of these. If you let me know which ones are outstanding I'll go and provide fixes. None of these in their own right are blockers but together I think they mark a backward step in terms of quality from 0.90. I would like to see another RC but as I'm so late in doing this have to vote -0.5. Get rid of svg files from the distribution Samples/README - overview samples list doesn't match current samples list calculator-rmi-reference ---------------------------------- Doesn't run for me from the command line. C:\simon\tuscany\r0.91-rc1\apache- tuscany-sca-0.91-incubating\tuscany-sca-0.91-i ncubating\samples\calculator-rmi-reference>ant run Buildfile: build.xml run: [java] Composite assembly problem: No targets for reference: addService [java] Composite assembly problem: No targets for reference: divideService [java] Composite assembly problem: No targets for reference: multiplyServic e [java] Composite assembly problem: No targets for reference: subtractServic e [java] Exception in thread "main" java.lang.NullPointerException [java] at calculator.CalculatorServiceImpl.add( CalculatorServiceImpl.ja va:54) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAcces sorImpl.java:64) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMet hodAccessorImpl.java:43) [java] at java.lang.reflect.Method.invoke(Method.java:615) [java] at org.apache.tuscany.sca.implementation.java.invocation.JavaTar getInvoker.invokeTarget(JavaTargetInvoker.java:112) [java] at org.apache.tuscany.sca.implementation.java.invocation.JavaTar getInvoker.invoke(JavaTargetInvoker.java:134) [java] at org.apache.tuscany.sca.implementation.java.invocation.TargetI nvokerInvoker.invoke(TargetInvokerInvoker.java:46) [java] at org.apache.tuscany.sca.core.invocation.AbstractInvocationHand ler.invoke(AbstractInvocationHandler.java:84) [java] at org.apache.tuscany.sca.core.invocation.JDKInvocationHandler.i nvoke(JDKInvocationHandler.java:73) [java] at $Proxy1.add(Unknown Source) [java] at calculator.CalculatorClient.main(CalculatorClient.java :35) [java] Java Result: 1 Calculator-webapp -------------------------- The ant file produces a war called sample-calculator-web.war rather than sample-calculator-webapp.war chat-webapp ------------------ has no README, diagram or ant build file. Here's the URL you need to use http://localhost:8080/sample-chat-webapp/ databining-echo ----------------------- C:\simon\tuscany\r0.91-rc1\apache- tuscany-sca-0.91-incubating\tuscany-sca-0.91-i ncubating\samples\databinding-echo>ant run Buildfile: build.xml run: [java] Exception in thread "main" org.osoa.sca.ServiceRuntimeException: jav a.lang.IllegalStateException: java.lang.ClassNotFoundException: echo.module.Echo ModuleActivator [java] at org.apache.tuscany.sca.host.embedded.SCADomain.createNewInsta nce(SCADomain.java:263) [java] at org.apache.tuscany.sca.host.embedded.SCADomain.newInstance(SC ADomain.java:68) [java] at dbecho.EchoDataBindingClient.main( EchoDataBindingClient.java: 31) [java] Caused by: java.lang.IllegalStateException: java.lang.ClassNotFoundE xception: echo.module.EchoModuleActivator [java] at org.apache.tuscany.sca.host.embedded.impl.ReallySmallRuntimeB uilder.getServices(ReallySmallRuntimeBuilder.java:276) [java] at org.apache.tuscany.sca.host.embedded.impl.ReallySmallRuntime. startModules(ReallySmallRuntime.java:154) [java] at org.apache.tuscany.sca.host.embedded.impl.ReallySmallRuntime. start(ReallySmallRuntime.java:115) [java] at org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.<i nit>(DefaultSCADomain.java:86) [java] at org.apache.tuscany.sca.host.embedded.SCADomain.createNewInsta nce(SCADomain.java:229) [java] ... 2 more [java] Caused by: java.lang.ClassNotFoundException: echo.module.EchoModuleA ctivator [java] at java.lang.Class.forName(Class.java:163) [java] at org.apache.tuscany.sca.host.embedded.impl.ReallySmallRuntimeB uilder.getServices(ReallySmallRuntimeBuilder.java:272) [java] ... 6 more [java] Java Result: 1 feed-aggregator ---------------------- no README, diagrams, ant build file helloworld-dojo --------------------- The ant file produces a war called sample-helloworldjsonrpc.war rather than sample-helloworld-dojo.war helloworld-jsonrpc -------------------------- What is the difference between this and helloworld-dojo? READMEs and diagrams are apparently the same. demo/bigbank-account demo/bigbank-calculator demo/bigbank-stockquote ------------------------------------- No README, diagrams or ant build files. This is a problem for the uninitiated. I set this demo up for SAOWorld and created a set up build.xmlfles to make life easier (which I could of course contribute) without them it's quite difficult to know what to do. demo/mortgage-creditcheck demo/morgage-loadapproval ----------------------------------------- No README, diagrams or ant build files I don't think we need .rulset file in creditcheck
