[ https://issues.apache.org/jira/browse/TUSCANY-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517639 ]
Fuhwei Lwo commented on TUSCANY-1397: ------------------------------------- The patch looks fine except the client code needs to handle IllegalStateException when invokes DataObject.createDataObject(String propertyName, String namespaceURI, String typeName) with non-existent type definition in the default helper context and IlegalArgumentException when the dataobject type is not open. Those exceptional behavior is not defined in the 2.1 spec either so I think whatever patch we have here is sufficient. > createDataObject() throws NPE if property does not exist > -------------------------------------------------------- > > Key: TUSCANY-1397 > URL: https://issues.apache.org/jira/browse/TUSCANY-1397 > Project: Tuscany > Issue Type: Bug > Components: Java SDO Implementation > Reporter: Andy Grove > Attachments: tuscany1397-v2.patch, tuscany1397.patch > > > Calling createDataObject( "foo" ) where the data object's type does not > define a property "foo" causes a null pointer exception in > DataObjectUtil.createDataObject(DataObject dataObject, Property property, > Type type) because it attempts to call property.isContainment without > checking if the property is null. > Calling createDataObject( "foo" ) on an open type should create an on-demand > property. If the type is not open and the property does not exist then an > exception should be thrown. > Thanks, > Andy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]